[Sugar-devel] Memorize 0001-Reorganize-icons.patch

Gonzalo Odiard gonzalo at laptop.org
Mon Oct 24 09:38:33 EDT 2011


On Mon, Oct 24, 2011 at 10:08 AM, Sascha Silbe <
sascha-ml-reply-to-2011-4 at silbe.org> wrote:

> Excerpts from Gonzalo Odiard's message of 2011-09-07 21:59:34 +0200:
> > One of the icons in this patch have a line longer than 998 characters,
> > but i don't know how to break it, because is a single path parameter.
>
> If you only moved the files rather than changing them, enable rename
> detection to only get diffs of the unchanged parts (the renames will
> still be mentioned, just not as separate remove+add hunks). As a bonus
> the patch is much easier to review this way.
>
> To enable rename detection, add "-M" to send-email / format-patch or set
> diff.renames to true or copies (the latter enables copy detection as
> well). E.g. to enable it for your entire user account (rather than an
> individual repository):
>
> git config --global diff.renames copies
>
>
Thanks by the tip.



> As for the patch: It doesn't apply cleanly to latest mainline master. As
> you seem to maintain Memorize these days, my guess is that the patch is
> obsolete and have marked it as such in Patchwork [1].
>
>
Yes, the patch is from two months ago.
Marked in patchwork

Gonzalo



> Sascha
>
> [1] https://patchwork.sugarlabs.org/patch/963/
> --
> http://sascha.silbe.org/
> http://www.infra-silbe.de/
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20111024/4bb983a7/attachment.html>


More information about the Sugar-devel mailing list