<br><br><div class="gmail_quote">On Mon, Oct 24, 2011 at 10:08 AM, Sascha Silbe <span dir="ltr"><<a href="mailto:sascha-ml-reply-to-2011-4@silbe.org">sascha-ml-reply-to-2011-4@silbe.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Excerpts from Gonzalo Odiard's message of 2011-09-07 21:59:34 +0200:<br>
<div class="im">> One of the icons in this patch have a line longer than 998 characters,<br>
> but i don't know how to break it, because is a single path parameter.<br>
<br>
</div>If you only moved the files rather than changing them, enable rename<br>
detection to only get diffs of the unchanged parts (the renames will<br>
still be mentioned, just not as separate remove+add hunks). As a bonus<br>
the patch is much easier to review this way.<br>
<br>
To enable rename detection, add "-M" to send-email / format-patch or set<br>
diff.renames to true or copies (the latter enables copy detection as<br>
well). E.g. to enable it for your entire user account (rather than an<br>
individual repository):<br>
<br>
git config --global diff.renames copies<br>
<br>
</blockquote><div><br>Thanks by the tip.<br><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
As for the patch: It doesn't apply cleanly to latest mainline master. As<br>
you seem to maintain Memorize these days, my guess is that the patch is<br>
obsolete and have marked it as such in Patchwork [1].<br>
<br></blockquote><div><br>Yes, the patch is from two months ago. <br>Marked in patchwork<br><br>Gonzalo<br><br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Sascha<br>
<br>
[1] <a href="https://patchwork.sugarlabs.org/patch/963/" target="_blank">https://patchwork.sugarlabs.org/patch/963/</a><br>
<font color="#888888">--<br>
<a href="http://sascha.silbe.org/" target="_blank">http://sascha.silbe.org/</a><br>
<a href="http://www.infra-silbe.de/" target="_blank">http://www.infra-silbe.de/</a><br>
</font><br>_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
<br></blockquote></div><br>