[Sugar-devel] [PATCH] fixes sl#2062

Sascha Silbe sascha-ml-ui-sugar-devel at silbe.org
Sat Jul 3 09:50:32 EDT 2010


Excerpts from Bernie Innocenti's message of Sat Jul 03 13:32:44 +0000 2010:
> > > -    except (Error, socket.error):
> > > +    except (Error, TypeError, socket.error):
> Tim, thank you very much for fixing this. I would like to include your
> fix in my Sugar 0.88 packages. Could you please repost the complete
> patch with this amendment included? (git commit --amend makes it easy)
This _is_ the complete patch. :D

FTR, this was my reasoning for amending the existing except block instead
of adding a new one:

2010-07-02 13:53:27 < silbe> timClicks: to me it's always just a failure to connect to the server. I'm not sure TypeError always implies lack of a network connection and other errors imply there's a network connection (but a different error occured), so I'd just always present the same message (and maybe change it to hint at establishing a network connection). But since you might know better I thought I'd ask first.

Sascha
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100703/26eb99b7/attachment.pgp 


More information about the Sugar-devel mailing list