[Sugar-devel] [PATCH] fixes sl#2062

[Bernie Innocenti]

El Sat, 03-07-2010 a las 12:41 +0000, Sascha Silbe escribió:
> Excerpts from Tim McNamara's message of Sat Jul 03 11:49:50 +0000 2010:
> 
> > diff --git a/src/jarabe/desktop/schoolserver.py
> > b/src/jarabe/desktop/schoolserver.py
> > index fc9ddeb..a05f56c 100644
> > --- a/src/jarabe/desktop/schoolserver.py
> > +++ b/src/jarabe/desktop/schoolserver.py
> > @@ -99,7 +99,7 @@ def register_laptop(url=REGISTER_URL):
> >      server = ServerProxy(url)
> >      try:
> >          data = server.register(sn, nick, uuid_, profile.pubkey)
> > -    except (Error, socket.error):
> > +    except (Error, TypeError, socket.error):
> >          logging.exception('Registration: cannot connect to server')
> >          raise RegisterError(_('Cannot connect to the server.'))
> 
> Reviewed-By: Sascha Silbe <sascha-pgp at silbe.org>

Tim, thank you very much for fixing this. I would like to include your
fix in my Sugar 0.88 packages. Could you please repost the complete
patch with this amendment included? (git commit --amend makes it easy)

Also, could you look into these related bugs?

 http://bugs.sugarlabs.org/ticket/1940
 http://bugs.sugarlabs.org/ticket/1977
 http://bugs.sugarlabs.org/ticket/1976

I'm trying to spread idea of letting children and teachers upgrade their
laptops without relying on technicians to do it. To lower the barrier,
it's important to make the Register procedure free of quirks.

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/