[Sugar-devel] Some possible git patches for Labyrinth-4

[Tomeu Vizoso]

On Sat, Dec 20, 2008 at 04:14, Gary C Martin <gary at garycmartin.com> wrote:
> Hi Tomeu (and other Sugar devs),
>
> Here's some patches for the Labyrinth-4  work created with:
>
>        git-format-patch 0d2bf1756d5f05b86a4f35ba8cbdb401b5cdb724
>
> That covers all the commits I've re-made here to a clone of your Labyrinth-4
> git rep:
>
>        http://gitorious.org/projects/labyrinth-sugar
>
> I'm still rough with git, workflow, et al, so shout if I could be making
> this easier for folks to work with. All of these patches so far (except the
> SVG icon) are to the upstream labyrinth source code to make it work a little
> better (and prettier) on Sugar. Is there some sort of magical OSS dance to
> waft some of these upstream, or is this effort considered a fork?

I guess it's a fork for now, but anyway we should try to reduce the
difference as much as possible, ideally just adding some sugar on top
of the unchanged upstream sources.

Subject: [PATCH] Added sugar friendly SVG activity icon.

Cool!

Subject: [PATCH] Allowed delete key event to work on links.

Sounds good, should be easily upstreamable.

Subject: [PATCH] Enabled curves by default.

We should be able to change this without modifying the upstream
sources. What about a property in MMArea?

Subject: [PATCH] Made thought boxes more rounded.

Same as above.

Subject: [PATCH] Make default thought colour white so that gtk
selection state is visible.

Same.

Subject: [PATCH] Use users XO colours for the primary thought.

Again ;)

Subject: [PATCH] Removed the fill on the bbox so you can see what
you're selecting...

Not sure, but may be as well a property that upstream can agree in adding.

> Patches were to:
>
> - Removed the fill on the bounding box so you can see what you're
> selecting...
> - Use users XO colours for the primary thought.
> - Make default thought colour white so that gtk selection state is visible.
> - Made thought boxes more rounded.
> - Enabled curves by default.
> - Allowed delete key event to work on links.
> - Added sugar friendly SVG activity icon.
>
> Eye candy:
>
>
>
>
>
> Perhaps I should just post patches to the sugar-dev list, it may nudge
> others into action and stop me from bothering Tomeu too much ;-) I guess I'd
> need to be able to push (accepted) patches to Tomeu's git rep, if that's the
> right procedure to aim for.

What if you take ownership of the project? I will be around whenever
you need it, and anyway I won't have much time to keep working on
this. I think you may be able to get more people involved in the near
future and I have some cool ideas about collaboration support that may
interest upstream as well ;)

Thanks a lot,

Tomeu