[Dextrose] [PATCH 54/54] Fix for bug au#694.
anish at activitycentral.org
Sat Nov 19 13:16:26 EST 2011
-----BEGIN PGP SIGNED MESSAGE-----
On 11/19/2011 11:42 PM, Sascha Silbe wrote:
> Excerpts from Anish Mangal's message of 2011-11-08 18:51:13 +0100:
>> except (xmlrpclib.Error, TypeError, socket.error):
>> logging.exception('Registration: cannot connect to server') -
>> raise RegisterError(_('Cannot connect to the server.')) +
>> raise RegisterError(_('No School Server found on the network. '
>> \ + 'Please ensure that you are
>> connected ' \ + 'to the correct
>> network and that the ' \ +
>> 'server is available.'))
> Since we don't distinguish between the different error cases, "No
> School Server found" isn't generic enough. We might have reached
> the XS (in which case it was "found"), but couldn't register for a
> different reason.
> There are two options:
> 1. Tune the error message to be more generic. Maybe just drop the
> first sentence of the long description; the summary already says
> all we actually know.
> 2. Look at the exceptions in detail (error codes or whatever) and
> output different messages depending on what exactly went wrong.
The second sentence would be good enough IMO. Copying Sridhar.
> PS: More verbose patch descriptions would be nice so I don't have
> to write them myself when merging patches.
+1, thanks for pointing out.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the Dextrose