[Dextrose] [PATCH 54/54] Fix for bug au#694.

[Anish Mangal]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Sascha,

On 11/19/2011 11:42 PM, Sascha Silbe wrote:
> Excerpts from Anish Mangal's message of 2011-11-08 18:51:13 +0100:
> 
>> except (xmlrpclib.Error, TypeError, socket.error): 
>> logging.exception('Registration: cannot connect to server') -
>> raise RegisterError(_('Cannot connect to the server.')) +
>> raise RegisterError(_('No School Server found on the network. '
>> \ +                              'Please ensure that you are
>> connected '   \ +                              'to the correct
>> network and that the '    \ +
>> 'server is available.'))
> 
> Since we don't distinguish between the different error cases, "No
> School Server found" isn't generic enough. We might have reached
> the XS (in which case it was "found"), but couldn't register for a
> different reason.
> 
> There are two options:
> 
> 1. Tune the error message to be more generic. Maybe just drop the
> first sentence of the long description; the summary already says
> all we actually know.
> 
> 2. Look at the exceptions in detail (error codes or whatever) and
> output different messages depending on what exactly went wrong.
> 
> 

The second sentence would be good enough IMO. Copying Sridhar.

> PS: More verbose patch descriptions would be nice so I don't have
> to write them myself when merging patches.
> 

+1, thanks for pointing out.

> Sascha
> 


- -- 
Anish
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJOx/J6AAoJEBoxUdDHDZVpFOMH/jnsx3jYbcYEi9oJdwQLjYCM
Ki9JRHUxsJQADrgpIpb0loKPhZH89KxbtYNoyX7xg/APjehHMtTBnuoK6vn2Yx5t
VyLMqyzGFmdqZ1BTjYw2PIYzsiS2G8Te3CEFaeuWmtbtmW5Wr6ndp3Oe6u6bFF0P
uf4quoVITHcDvXIB5hF6edPFJ3LDcjCnUFJ14lWTXd3SCygD4HHusNiGEE5ot88e
2wOMabfhZTLF4QBAouSzHD6OXGGXZFTN+i9nZCoA//wt43JIVdejO3SWpqL9cBcZ
vkvNe1Vu7OhTonkIj04cLxTvA9q3r3LMhW+TNOasr7Bz77LcqFctdxWfyopjczY=
=omTy
-----END PGP SIGNATURE-----