[Dextrose] [PATCH 54/54] Fix for bug au#694.

[Sascha Silbe]

Excerpts from Anish Mangal's message of 2011-11-08 18:51:13 +0100:

>      except (xmlrpclib.Error, TypeError, socket.error):
>          logging.exception('Registration: cannot connect to server')
> -        raise RegisterError(_('Cannot connect to the server.'))
> +        raise RegisterError(_('No School Server found on the network. ' \
> +                              'Please ensure that you are connected '   \
> +                              'to the correct network and that the '    \
> +                              'server is available.'))

Since we don't distinguish between the different error cases, "No School
Server found" isn't generic enough. We might have reached the XS (in
which case it was "found"), but couldn't register for a different
reason.

There are two options:

1. Tune the error message to be more generic. Maybe just drop the first
   sentence of the long description; the summary already says all we
   actually know.

2. Look at the exceptions in detail (error codes or whatever) and output
   different messages depending on what exactly went wrong.


PS: More verbose patch descriptions would be nice so I don't have to
    write them myself when merging patches.

Sascha

-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/dextrose/attachments/20111119/fda4bccd/attachment.pgp>