[Sugar-devel] [sugarlabs/sugar] Revert "Fixed Issue: #4940 Journal entries name can be renamed to blank" (#752)

Tony Anderson tony_anderson at usa.net
Wed Apr 26 02:14:26 EDT 2017

The issue #4940 was well taken. The fix should have been applied.

Back in the day, a customer wanted to show off his hospital database. 
His query was for patients older that 100. He was amazed to see huge 
list. Turned out that date of birth had been left blank and so the epoch 
date zero was used, January 1, 1601. Not one person suggested that since 
that was the way SHAS worked, that was the way it should be. The IT 
folks put a verification check in within hours. It took a little longer 
to collect the correct dates of birth.

The title does need to be non-blank so the user looking at the Journal 
View can tell which object is which.  Why should a blank or empty title 
not be considered a mistake?


On 04/26/2017 12:13 PM, James Cameron wrote:
> This reverts commit e05452a 
> <https://github.com/sugarlabs/sugar/commit/e05452a571ef9366b2e44d3c9c28d1b6182c4b50> 
> as the current behaviour is inconsistent across Sugar.
> An journal entry title does not need to be non-blank; the learner 
> should be allowed to use a blank or empty title. The title can always 
> be changed again.
> The default title is never blank. The title does not need to be 
> unique; it is not a file name.
> Reference:
> https://bugs.sugarlabs.org/ticket/4940
> ------------------------------------------------------------------------
>         You can view, comment on, or merge this pull request online at:
> https://github.com/sugarlabs/sugar/pull/752
>         Commit Summary
>   * Revert "Fixed Issue: #4940 Journal entries name can be renamed to
>     blank"
>         File Changes
>   * *M* src/jarabe/journal/listview.py
>     <https://github.com/sugarlabs/sugar/pull/752/files#diff-0> (4)
>         Patch Links:
>   * https://github.com/sugarlabs/sugar/pull/752.patch
>   * https://github.com/sugarlabs/sugar/pull/752.diff
>> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub 
> <https://github.com/sugarlabs/sugar/pull/752>, or mute the thread 
> <https://github.com/notifications/unsubscribe-auth/AAULkkLhDqeXyCBTigFR_UOmLzHN-EYJks5rzsRSgaJpZM4NIV2L>.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20170426/c7608a8b/attachment.html>

More information about the Sugar-devel mailing list