<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
The issue #4940 was well taken. The fix should have been applied.<br>
<br>
Back in the day, a customer wanted to show off his hospital
database. His query was for patients older that 100. He was amazed
to see huge list. Turned out that date of birth had been left blank
and so the epoch date zero was used, January 1, 1601. Not one person
suggested that since that was the way SHAS worked, that was the way
it should be. The IT folks put a verification check in within hours.
It took a little longer to collect the correct dates of birth.<br>
<br>
The title does need to be non-blank so the user looking at the
Journal View can tell which object is which. Why should a blank or
empty title not be considered a mistake?<br>
<br>
Tony<br>
<br>
<div class="moz-cite-prefix">On 04/26/2017 12:13 PM, James Cameron
wrote:<br>
</div>
<blockquote cite="mid:sugarlabs%2Fsugar%2Fpull%2F752@github.com"
type="cite">
<p>This reverts commit <a moz-do-not-send="true"
href="https://github.com/sugarlabs/sugar/commit/e05452a571ef9366b2e44d3c9c28d1b6182c4b50"
class="commit-link"><tt>e05452a</tt></a> as the current
behaviour is inconsistent across Sugar.</p>
<p>An journal entry title does not need to be non-blank; the
learner should be allowed to use a blank or empty title. The
title can always be changed again.</p>
<p>The default title is never blank. The title does not need to be
unique; it is not a file name.</p>
<p>Reference:<br>
<a moz-do-not-send="true"
href="https://bugs.sugarlabs.org/ticket/4940">https://bugs.sugarlabs.org/ticket/4940</a></p>
<hr>
<h4>You can view, comment on, or merge this pull request online
at:</h4>
<p> <a moz-do-not-send="true"
href="https://github.com/sugarlabs/sugar/pull/752">https://github.com/sugarlabs/sugar/pull/752</a></p>
<h4>Commit Summary</h4>
<ul>
<li>Revert "Fixed Issue: #4940 Journal entries name can be
renamed to blank"</li>
</ul>
<h4>File Changes</h4>
<ul>
<li> <strong>M</strong> <a moz-do-not-send="true"
href="https://github.com/sugarlabs/sugar/pull/752/files#diff-0">src/jarabe/journal/listview.py</a>
(4) </li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a moz-do-not-send="true"
href="https://github.com/sugarlabs/sugar/pull/752.patch">https://github.com/sugarlabs/sugar/pull/752.patch</a></li>
<li><a moz-do-not-send="true"
href="https://github.com/sugarlabs/sugar/pull/752.diff">https://github.com/sugarlabs/sugar/pull/752.diff</a></li>
</ul>
<p
style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
You are receiving this because you are subscribed to this
thread.<br>
Reply to this email directly, <a moz-do-not-send="true"
href="https://github.com/sugarlabs/sugar/pull/752">view it on
GitHub</a>, or <a moz-do-not-send="true"
href="https://github.com/notifications/unsubscribe-auth/AAULkkLhDqeXyCBTigFR_UOmLzHN-EYJks5rzsRSgaJpZM4NIV2L">mute
the thread</a>.<img moz-do-not-send="true" alt=""
src="https://github.com/notifications/beacon/AAULkpjjYIau0jTUGdn9d8RmupK0q888ks5rzsRSgaJpZM4NIV2L.gif"
height="1" width="1"></p>
<div itemscope="" itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope=""
itemtype="http://schema.org/ViewAction">
<link itemprop="url"
href="https://github.com/sugarlabs/sugar/pull/752">
<meta itemprop="name" content="View Pull Request">
</div>
<meta itemprop="description" content="View this Pull Request on
GitHub">
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/sugarlabs/sugar","title":"sugarlabs/sugar","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/sugarlabs/sugar"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Revert \"Fixed Issue: #4940 Journal entries name can be renamed to blank\" (#752)"}],"action":{"name":"View Pull Request","url":"https://github.com/sugarlabs/sugar/pull/752"}}}</script>
</blockquote>
<br>
</body>
</html>