[Sugar-devel] [sugar-toolkit-gtk3] Allow to load pixbufs into surface cache for using X11 window hints. (7c6f87a)

[Sebastian Silva]

Missed to attach the patch.

El sáb, 22 de mar 2014 a las 12:31 AM, Sebastian Silva 
<sebastian at fuentelibre.org> escribió:
> Hi Daniel,
> Thanks a lot for the review.
> 
> I don't know if this is the correct way to submit a question, I have 
> looked everywhere for API docs of GdkPixbuf.hash and can't seem to 
> find it. It requires a parameter but I don't know what it's supposed 
> to be 
> 
> Try as I might, from the interactive interpreter it even segfaults on 
> me when trying values for this parameter.
> 
> I think I more or less got your suggestion in the attached patch but 
> I still need to make the Pixbuf.hash function work.
> 
> Thanks for your advice,
> Sebastian
> 
> El vie, 21 de mar 2014 a las 5:42 AM, Daniel Narvaez 
> <notifications at github.com> escribió:
>> I think it would be hard to support insensitive/badge while 
>> bypassing the cache. Also I've seen that hash() is basically free 
>> because it's pointer based. So maybe the best approach is to make 
>> IconBuffer.get_surface handle self.pixbuf, using hash() for the key? 
>> That means we keep around both the pixbuf and the surface which is a 
>> bit of waste, but I can't think of a way to avoid that without 
>> making very large changes. It won't have a user visible impact for 
>> the stuff you are doing so maybe we can deal with that issue if/when 
>> we start using big/lots of pixbufs.
>> 
>> —
>> Reply to this email directly or view it on GitHub.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20140322/7ce09fef/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Allow-to-load-pixbufs-into-icon.patch
Type: text/x-patch
Size: 5261 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20140322/7ce09fef/attachment.bin>