[Sugar-devel] [sugar-web] bug in the activity palette at the Home view

[Suraj K S]

Hi Manuel,

I'm afraid even https://github.com/sugarlabs/sugar-web/pull/71/files still
doesn't completely fix the problem.

Try this:
1) Open activity.
2) Change the activity title in the activity palette. Then close the
activity.
3)Open then open the activity again. You'll find the default activity
title. (Your previous title will have been overwritten)

I think this is because activity.setup() is called every time an activity
is opened.
So when you do this
https://github.com/sugarlabs/sugar-web/pull/71/files#L0R44 in
env.getEnvironment(), every time the activity is opened the old title value
is overwritten.

I guess we'd have to put in a condition there.



On 31 July 2013 05:22, Manuel Quiñones <manuq at laptop.org> wrote:

> Moving the discussion from github, answering Suraj comment:
>
>
> https://github.com/sugarlabs/sugar-web/commit/ca60d8166161b49ea4f7bc091145b1b00e72c779#commitcomment-3751549
>
> You are totally right Suraj. the bug remains.  TestCase:
>
> - start web activity from scratch
> - stop it without doing anything
> - try to pop up the activity palette in the home view --> nothing happens
>
> We should do the same initialization as GTK activity does, in
> sugar3/activity/activity.py
>
> Here is a pull-request that fixes it, and also adds the
> 'title_set_by_user' metadata.
>
> https://github.com/sugarlabs/sugar-web/pull/71/files
>
> --
> .. manuq ..
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20130731/ae6e4f10/attachment.html>