<div dir="ltr"><div>Hi Manuel,</div><div><br></div>I'm afraid even <a href="https://github.com/sugarlabs/sugar-web/pull/71/files" target="_blank" style="font-family:arial,sans-serif;font-size:13px">https://github.com/sugarlabs/sugar-web/pull/71/files</a> still doesn't completely fix the problem.<div>
<br></div><div>Try this:<br>1) Open activity.</div><div>2) Change the activity title in the activity palette. Then close the activity.</div><div>3)Open then open the activity again. You'll find the default activity title. (Your previous title will have been overwritten)</div>
<div><br></div><div>I think this is because activity.setup() is called every time an activity is opened.</div><div>So when you do this <a href="https://github.com/sugarlabs/sugar-web/pull/71/files#L0R44">https://github.com/sugarlabs/sugar-web/pull/71/files#L0R44</a> in env.getEnvironment(), every time the activity is opened the old title value is overwritten.</div>
<div><br></div><div>I guess we'd have to put in a condition there.</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On 31 July 2013 05:22, Manuel Quiñones <span dir="ltr"><<a href="mailto:manuq@laptop.org" target="_blank">manuq@laptop.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Moving the discussion from github, answering Suraj comment:<br>
<br>
<a href="https://github.com/sugarlabs/sugar-web/commit/ca60d8166161b49ea4f7bc091145b1b00e72c779#commitcomment-3751549" target="_blank">https://github.com/sugarlabs/sugar-web/commit/ca60d8166161b49ea4f7bc091145b1b00e72c779#commitcomment-3751549</a><br>
<br>
You are totally right Suraj. the bug remains. TestCase:<br>
<br>
- start web activity from scratch<br>
- stop it without doing anything<br>
- try to pop up the activity palette in the home view --> nothing happens<br>
<br>
We should do the same initialization as GTK activity does, in<br>
sugar3/activity/activity.py<br>
<br>
Here is a pull-request that fixes it, and also adds the<br>
'title_set_by_user' metadata.<br>
<br>
<a href="https://github.com/sugarlabs/sugar-web/pull/71/files" target="_blank">https://github.com/sugarlabs/sugar-web/pull/71/files</a><br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
.. manuq ..<br>
_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
</font></span></blockquote></div><br></div>