[Sugar-devel] Build broken, sugar

[Daniel Narvaez]

Hi Miguel,

those looks different, they import from the extensions dir inside the tests
directory which contains a couple of mock extensions we are using for web
services tests.


On 5 August 2013 09:46, Miguel González <migonzalvar at activitycentral.com>wrote:

> I also think this is the best approach.
>
> Please, note that these files also have "sys.path.append(config.ext_path)":
>
> tests/views/webaccount.py:33
> tests/views/journal_detailstoolbox.py:41
> tests/test_webservice.py:39
>
> Maybe now it's redundant too.
>
>
>
> On Sun, Aug 4, 2013 at 9:31 PM, Daniel Narvaez <dwnarvaez at gmail.com>wrote:
>
>> I take that back, I'm not sure setUpModule was not called, I was doing
>> something stupid.
>>
>> Anyway I simplified import extensions in unit tests
>>
>>
>> https://github.com/sugarlabs/sugar/commit/fa80c7d7b6d45a627ba4b1f8983d65bbe482a641
>>
>> That also seems to fix the failure. I pushed to fix the build but reviews
>> are of course welcome.
>>
>>
>> On 4 August 2013 19:38, Daniel Narvaez <dwnarvaez at gmail.com> wrote:
>>
>>> Seeing this on the new buildbot i386 slave I setup. setUpModule seems to
>>> not be called, at least I put an error in it and I'm not seeing it in the
>>> output. python is 2.7.5, not really sure what is going on.
>>>
>>>
>>> On 30 July 2013 16:53, Miguel González <migonzalvar at activitycentral.com>wrote:
>>>
>>>> Gonzalo, what version of python do you use?
>>>>
>>>> sys.path is modified in tests/test_modemconfiguration.py:27
>>>>
>>>> ```
>>>> def setUpModule():
>>>>     sys.path.append(config.ext_path)
>>>> ```
>>>>
>>>> It's seem this setup method is supported in Python 2.7 but not in
>>>> previous versions [1]. For Python 2.6 requieres unittest2 backport. [2]
>>>>
>>>> [1]
>>>> http://www.voidspace.org.uk/python/articles/unittest2.shtml#setupmodule-and-teardownmodule
>>>>
>>>> [2] https://pypi.python.org/pypi/unittest2
>>>>
>>>>
>>>> On Tue, Jul 30, 2013 at 3:01 PM, Gonzalo Odiard <gonzalo at laptop.org>wrote:
>>>>
>>>>> Looks right
>>>>>
>>>>> ext_path =
>>>>> '/home/gonzalo/sugar-build/build/out/install/share/sugar/extensions'
>>>>>
>>>>>
>>>>>
>>>>> On Tue, Jul 30, 2013 at 9:05 AM, Daniel Narvaez <dwnarvaez at gmail.com>wrote:
>>>>>
>>>>>> So weird, I wonder if your src/jarabe/config.py has the right
>>>>>> ext_path?
>>>>>>
>>>>>>
>>>>>> On Tuesday, 30 July 2013, Gonzalo Odiard wrote:
>>>>>>
>>>>>>> That run without problems, but the check gives me the same error,
>>>>>>> even running in the osbuild shell.
>>>>>>>
>>>>>>> Gonzalo
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Jul 30, 2013 at 7:25 AM, Daniel Narvaez <dwnarvaez at gmail.com
>>>>>>> > wrote:
>>>>>>>
>>>>>>> I've seen from irc that you have the file... Please try to run a
>>>>>>> script like this (edit the path)
>>>>>>>
>>>>>>> import sys
>>>>>>>
>>>>>>> sys.path.append("/home/broot/sugar-build/build/out/install/share/sugar/extensions/")
>>>>>>> from cpsection.modemconfiguration.model import ServiceProvidersParser
>>>>>>>
>>>>>>> If it fails, please run it under strace and post the output. That
>>>>>>> should tell us where it's failing exactly.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On 30 July 2013 11:08, Daniel Narvaez <dwnarvaez at gmail.com> wrote:
>>>>>>>
>>>>>>> I cannot reproduce on master either. Does
>>>>>>> build/out/install/share/sugar/extensions/cpsection/modemconfiguration/model.py
>>>>>>> exist?
>>>>>>>
>>>>>>>
>>>>>>> On 29 July 2013 22:21, Gonzalo Odiard <gonzalo at laptop.org> wrote:
>>>>>>>
>>>>>>> Master.
>>>>>>>
>>>>>>> Full log: http://paste.fedoraproject.org/28781/29226137/
>>>>>>>
>>>>>>> Gonzalo
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Jul 29, 2013 at 5:04 PM, Daniel Narvaez <dwnarvaez at gmail.com
>>>>>>> > wrote:
>>>>>>>
>>>>>>> Weird. Master or chroot branch? It would be good to post the full
>>>>>>> trace.
>>>>>>>
>>>>>>>
>>>>>>> On Monday, 29 July 2013, Gonzalo Odiard wrote:
>>>>>>>
>>>>>>>  In my system, running osbuild check get:
>>>>>>>
>>>>>>> ImportError: No module named modemconfiguration.model
>>>>>>>
>>>>>>> in all the modemconfiguration tests.
>>>>>>>
>>>>>>> All is updated. Tried running, building, pulling and all.
>>>>>>>
>>>>>>> Gonzalo
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Jul 29, 2013 at 9:44 AM, Miguel González <
>>>>>>> migonzalvar at activitycentral.com> wrote:
>>>>>>>
>>>>>>> Good news! Thank you very much!
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Jul 29, 2013 at 2:41 PM, Daniel Narvaez <dwnarvaez at gmail.com
>>>>>>> > wrote:
>>>>>>>
>>>>>>> Fixed, gconf was not working at all in the chroot branch. Your tests
>>>>>>> are all passing now!
>>>>>>>
>>>>>>>
>>>>>>> On 29 July 2013 12:51, Miguel González <
>>>>>>> migonzalvar at activitycentral.com> wrote:
>>>>>>>
>>>>>>> OK. Please, take into account I can mock GConf on every test but I
>>>>>>> don't know if that makes sense.
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Jul 29, 2013 at 12:33 PM, Daniel Narvaez <
>>>>>>> dwnarvaez at gmail.com> wrote:
>>>>>>>
>>>>>>> Landed your pull request. Now it fails in gconf but I think that's a
>>>>>>> sugar-build issue, I will take a look at that.
>>>>>>>
>>>>>>> Thanks.
>>>>>>>
>>>>>>>
>>>>>>> On 29 July 2013 10:44, Miguel González <
>>>>>>> migonzalvar at activitycentral.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>> Here is my patch: it checks if language code is not defined and use
>>>>>>> default values in that case.
>>>>>>>
>>>>>>> [https://github.com/sugarlabs/sugar/pull/71]
>>>>>>>
>>>>>>> diff --git a/extensions/cpsection/modemc
>>>>>>>
>>>>>>>
>>>>>>
>>>>>> --
>>>>>> Daniel Narvaez
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Miguel González
>>>> Activity Central: http://www.activitycentral.com
>>>>
>>>
>>>
>>>
>>> --
>>> Daniel Narvaez
>>>
>>
>>
>>
>> --
>> Daniel Narvaez
>>
>
>
>
> --
> Miguel González
> Activity Central: http://www.activitycentral.com
>



-- 
Daniel Narvaez
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20130805/a09ed9e9/attachment-0001.html>