<div dir="ltr"><div>Hi Miguel,<br><br></div>those looks different, they import from the extensions dir inside the tests directory which contains a couple of mock extensions we are using for web services tests.<br></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On 5 August 2013 09:46, Miguel González <span dir="ltr"><<a href="mailto:migonzalvar@activitycentral.com" target="_blank">migonzalvar@activitycentral.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div>I also think this is the best approach.<br><br>Please, note that these files also have "sys.path.append(config.ext_path)":<br><br>tests/views/webaccount.py:33<br>tests/views/journal_detailstoolbox.py:41<br>
tests/test_webservice.py:39<br><br></div>Maybe now it's redundant too.<br><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Aug 4, 2013 at 9:31 PM, Daniel Narvaez <span dir="ltr"><<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>I take that back, I'm not sure setUpModule was not called, I was doing something stupid.<br><br>
Anyway I simplified import extensions in unit tests<br><br><a href="https://github.com/sugarlabs/sugar/commit/fa80c7d7b6d45a627ba4b1f8983d65bbe482a641" target="_blank">https://github.com/sugarlabs/sugar/commit/fa80c7d7b6d45a627ba4b1f8983d65bbe482a641</a><br>
<br></div>That also seems to fix the failure. I pushed to fix the build but reviews are of course welcome.<br></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On 4 August 2013 19:38, Daniel Narvaez <span dir="ltr"><<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Seeing this on the new buildbot i386 slave I setup. setUpModule seems to not be called, at least I put an error in it and I'm not seeing it in the output. python is 2.7.5, not really sure what is going on.<br>
</div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On 30 July 2013 16:53, Miguel González <span dir="ltr"><<a href="mailto:migonzalvar@activitycentral.com" target="_blank">migonzalvar@activitycentral.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Gonzalo, what version of python do you use?<br><br>sys.path is modified in tests/test_modemconfiguration.py:27<br>
<br>```<br>def setUpModule():<br> sys.path.append(config.ext_path)<br>```<br><br></div>
<div>It's seem this setup method is supported in Python 2.7 but not in previous versions [1]. For Python 2.6 requieres unittest2 backport. [2]<br><br>[1] <a href="http://www.voidspace.org.uk/python/articles/unittest2.shtml#setupmodule-and-teardownmodule" target="_blank">http://www.voidspace.org.uk/python/articles/unittest2.shtml#setupmodule-and-teardownmodule</a><br>
<br>[2] <a href="https://pypi.python.org/pypi/unittest2" target="_blank">https://pypi.python.org/pypi/unittest2</a><br></div></div><div class="gmail_extra"><div><div><br><br><div class="gmail_quote">On Tue, Jul 30, 2013 at 3:01 PM, Gonzalo Odiard <span dir="ltr"><<a href="mailto:gonzalo@laptop.org" target="_blank">gonzalo@laptop.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Looks right<div><div><br></div><div>ext_path = '/home/gonzalo/sugar-build/build/out/install/share/sugar/extensions'</div>
</div><div><br></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, Jul 30, 2013 at 9:05 AM, Daniel Narvaez <span dir="ltr"><<a href="mailto:dwnarvaez@gmail.com" target="_blank">dwnarvaez@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
So weird, I wonder if your src/jarabe/<span></span>config.py has the right ext_path?<div><div><br><br>On Tuesday, 30 July 2013, Gonzalo Odiard wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">That run without problems, but the check gives me the same error, even running in the osbuild shell.<div><br></div><div>Gonzalo</div></div><div><br><br><div>On Tue, Jul 30, 2013 at 7:25 AM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>I've seen from irc that you have the file... Please try to run a script like this (edit the path)<br>
<br></div><div>import sys<br>sys.path.append("/home/broot/sugar-build/build/out/install/share/sugar/extensions/")<br>
from cpsection.modemconfiguration.model import ServiceProvidersParser<br><br></div><div>If it fails, please run it under strace and post the output. That should tell us where it's failing exactly.<br></div><div><br></div>
</div><div><div><div><br><br><div>On 30 July 2013 11:08, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">I cannot reproduce on master either. Does build/out/install/share/sugar/extensions/cpsection/modemconfiguration/model.py exist?<br></div><div><div><div><br><br><div>
On 29 July 2013 22:21, Gonzalo Odiard <span dir="ltr"><<a>gonzalo@laptop.org</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Master.<div><br></div><div>Full log: <a href="http://paste.fedoraproject.org/28781/29226137/" target="_blank">http://paste.fedoraproject.org/28781/29226137/</a></div>
<span><font color="#888888"><div><br></div><div>Gonzalo</div></font></span></div><div><div><div>
<br><br><div>On Mon, Jul 29, 2013 at 5:04 PM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Weird. Master or chroot branch? It would be good to post the full trace.<div><div><span></span><br><br>On Monday, 29 July 2013, Gonzalo Odiard wrote:<br></div></div><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>
<div dir="ltr">In my system, running osbuild check get:<div><br></div><div><div>ImportError: No module named modemconfiguration.model</div></div><div><br></div><div>in all the modemconfiguration tests.</div><div><br></div>
<div>All is updated. Tried running, building, pulling and all.</div><div><br></div><div>Gonzalo </div></div></div></div><div><br><br><div><div><div>On Mon, Jul 29, 2013 at 9:44 AM, Miguel González <span dir="ltr"><<a>migonzalvar@activitycentral.com</a>></span> wrote:<br>
</div></div><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">Good news! Thank you very much!<br></div><div><div><div><br>
<br><div>On Mon, Jul 29, 2013 at 2:41 PM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Fixed, gconf was not working at all in the chroot branch. Your tests are all passing now!<br></div><div>
<div><div><br><br><div>On 29 July 2013 12:51, Miguel González <span dir="ltr"><<a>migonzalvar@activitycentral.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">OK. Please, take into account I can mock GConf on every test but I don't know if that makes sense.<br>
</div><div><div><div><br><br><div>On Mon, Jul 29, 2013 at 12:33 PM, Daniel Narvaez <span dir="ltr"><<a>dwnarvaez@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Landed your pull request. Now it fails in gconf but I think that's a sugar-build issue, I will take a look at that.<br>
<br></div>Thanks.<br></div><div><div><div><br><br><div>
On 29 July 2013 10:44, Miguel González <span dir="ltr"><<a>migonzalvar@activitycentral.com</a>></span> wrote:<br><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><br>Here is my patch: it checks if language code is not defined and use default values in that case.<br><br>[<a href="https://github.com/sugarlabs/sugar/pull/71" target="_blank">https://github.com/sugarlabs/sugar/pull/71</a>]<br>
<br>diff --git a/extensions/cpsection/modemc</div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div></div></div></div></blockquote>
</div></div></blockquote></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></div></div></blockquote></div></div></blockquote><br><br></div></div><span><font color="#888888">-- <br>
Daniel Narvaez<br><br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br><br clear="all"><br></div></div><div>-- <br><div dir="ltr">Miguel González<br>Activity Central: <a href="http://www.activitycentral.com" target="_blank">http://www.activitycentral.com</a><br>
</div>
</div></div>
</blockquote></div><br><br clear="all"><br></div></div><span><font color="#888888">-- <br>Daniel Narvaez<br>
</font></span></div>
</blockquote></div><br><br clear="all"><br></div></div><span><font color="#888888">-- <br>Daniel Narvaez<br>
</font></span></div>
</blockquote></div><br><br clear="all"><br>-- <br><div dir="ltr">Miguel González<br>Activity Central: <a href="http://www.activitycentral.com" target="_blank">http://www.activitycentral.com</a><br></div>
</div>
</div></div></blockquote></div><br><br clear="all"><br>-- <br>Daniel Narvaez<br>
</div>