[Sugar-devel] [PATCH Browse] Cancel a download if space is very tight SL #394

[Manuel Kaufmann]

On Tue, Sep 11, 2012 at 1:37 PM, Martin Langhoff
<martin.langhoff at gmail.com> wrote:
>  - check at the start of the download that it'll fit (with X room to spare)

This is done in the new version of the patch that I sent.

>  - make damn sure that we handle ENOSPC if the disk does fill up

I think we can create a new ticket for this feature, and manage it in
a separate patch. In fact, I have some questions about this and I have
to research for a while. Now, is the datastore raising that exception
when the space is not enough or I have to implement it? If it's
already implemented, how I can catch it?

I did a "git grep ENOSPC" inside the "sugar-datastore" source code and
I didn't find anything.


On Tue, Sep 11, 2012 at 6:34 PM, Hal Murray <hmurray at megapathdsl.net> wrote:
> martin.langhoff at gmail.com said:
>> Checking in the progress bar... it's optional. Up to you if you want to
>> check there _as well_.
>
> Sometimes, you don't know at the start how big a download will be.
>
> In that case, if you want to stop before filling up the disk, you have to
> check often-enough during the download.  The progress bar sounds like a good
> place.

I'm confused here. Are we going to check this in two different places?
The first one, when the download process is about to start and every
time that Browse gets a new chunk of the file. In case that we are
going to implement this approach, Gonzalo suggested me to check it
every 5Mb downloaded for example instead of every chunk.

Please, fill a new ticket with this approach if we are going to
implement this feature.

-- 
Kaufmann Manuel
Blog: http://humitos.wordpress.com/
Porfolio: http://fotos.mkaufmann.com.ar/
PyAr: http://www.python.com.ar/