[Sugar-devel] [PATCH Browse] Cancel a download if space is very tight SL #394

Martin Langhoff martin.langhoff at gmail.com
Tue Sep 11 09:37:28 EDT 2012


On Tue, Sep 11, 2012 at 9:01 AM, Manuel Kaufmann <humitos at gmail.com> wrote:
> If we are going to use this approach, I have to change the logic about
> "where" I should check this.

+200. I hadn't realized this. The main two things you absolutely need are

 - check at the start of the download that it'll fit (with X room to spare)
 - make damn sure that we handle ENOSPC if the disk does fill up

Checking in the progress bar... it's optional. Up to you if you want
to check there _as well_.

cheers,


m
-- 
 martin.langhoff at gmail.com
 martin at laptop.org -- Software Architect - OLPC
 - ask interesting questions
 - don't get distracted with shiny stuff  - working code first
 - http://wiki.laptop.org/go/User:Martinlanghoff


More information about the Sugar-devel mailing list