[Sugar-devel] gestures + event controller patch series

Simon Schampijer simon at schampijer.de
Wed Sep 5 13:07:19 EDT 2012


On 09/05/2012 02:04 PM, Carlos Garnacho wrote:
> Hey,
>
> I'm sending an updated patch set. There was a missing header in the
> previous set, and now there's code to show UI feedback on long press
>
>    Carlos

Hey Carlos,

awesome work, looking really good already. While spinning an rpm for 
testing [1] I came across that we install the headers, not sure we need 
that. Really minor thing though.

diff --git a/src/sugar3/event-controller/Makefile.am 
b/src/sugar3/event-controller/Makefile.am
index 65b0f1c..be7d2fa 100644
--- a/src/sugar3/event-controller/Makefile.am
+++ b/src/sugar3/event-controller/Makefile.am
@@ -31,9 +31,6 @@ libsugar_eventcontroller_la_SOURCES = \
         $(eventcontroller_h_sources)    \
         $(eventcontroller_c_sources)

-libsugar_eventcontrollerinclude_HEADERS = \
-       $(eventcontroller_h_sources)
-
  BUILT_SOURCES =                        \
         sugar-enum-types.c              \
         sugar-enum-types.h
[erikos at t61 sugar-toolkit-gtk3]$ git commit 
src/sugar3/event-controller/Makefile.am
[master 8d32e18] Don't install the headers
  1 file changed, 3 deletions(-)

I will have a look at the API next and test a bit, a first swipe-test 
app is attached.

Thanks,
    Simon

[1] http://arm.koji.fedoraproject.org/koji/taskinfo?taskID=1119948
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gestures.py
Type: text/x-python
Size: 717 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120905/27c68444/attachment.py>


More information about the Sugar-devel mailing list