[Sugar-devel] [PATCH 3/5] sl#2816: Localization fixes.

[Simon Schampijer]

On 02/09/2012 09:02 AM, Simon Schampijer wrote:
> On 01/23/2012 06:01 PM, Sascha Silbe wrote:
>> Excerpts from Ajay Garg's message of 2012-01-19 22:36:08 +0100:
>>
>> Like mentioned for the first patch in the series (BTW, please post
>> series as a thread (git send-email --thread; this option is enabled by
>> default so you seem to have explicitly deactivated it), please provide a
>> better description than just "Localization fixes").
>>
>>
>> [data/sugar.schemas.in]
>>> @@ -218,7 +218,7 @@
>>> <type>bool</type>
>>> <default>false</default>
>>> <locale name="C">
>>> -<short>Power Automatic</short>
>>> +<short>Power Automatic.</short>
>>> <long>Power Automatic.</long>
>>> </locale>
>>> </schema>
>>> @@ -229,7 +229,7 @@
>>> <type>bool</type>
>>> <default>false</default>
>>> <locale name="C">
>>> -<short>Power Extreme</short>
>>> +<short>Power Extreme.</short>
>>> <long>Power Extreme.</long>
>>> </locale>
>>> </schema>
>>
>> I wouldn't mind us accepting this patch to make the lives of our
>> translators easier, but the existing descriptions are rather poor and
>> should be fixed. We could take the strings from
>> extensions/cpsection/power/view.py:
>>
>> Automatic power management (increases battery life)
>>
>> Extreme power management (disables wireless radio, increases battery
>> life)
>>
>> Reusing those strings as-is would achieve the goal of SL#2816 and at
>> the same time improve the gconf descriptions.
>>
>> Sascha
>
> Good Idea, I would do then:
>
> diff --git a/data/sugar.schemas.in b/data/sugar.schemas.in
> index e048c37..763aa38 100644
> --- a/data/sugar.schemas.in
> +++ b/data/sugar.schemas.in
> @@ -152,7 +152,7 @@
> <default>false</default>
> <locale name="C">
> <short>Power Automatic</short>
> - <long>Power Automatic.</long>
> + <long>Automatic power management (increases battery life)</long>
> </locale>
> </schema>
> <schema>
> @@ -163,7 +163,7 @@
> <default>false</default>
> <locale name="C">
> <short>Power Extreme</short>
> - <long>Power Extreme. </long>
> + <long>Extreme power management (disables wireless radio, increases
> battery life)</long>
> </locale>
> </schema>
>
> @Chris: Looks like we need to cleanup the po files then after those
> changes. An extract from the german po.
>
> #~ msgid "Power Automatic."
> #~ msgstr "Automatische Energieverwaltung."
>
> # (Markus S.) war 'Extreme Energieverwaltung'
> #~ msgid "Power Extreme."
> #~ msgstr "Extremes Energiesparen."
>
> Regards,
> Simon

Pushed that one now, to not get it stale: 
72a7278f2803c5f13d55226af82ada1a8f8e714d

Regards,
    Simon