[Sugar-devel] [PATCH Log v2] Don't update search results every keystroke

[Gary Martin]

On 13 Apr 2012, at 04:47, Gonzalo Odiard wrote:

> May be for consistency is better add the timeout. Anyway, if the user press
> enter the search is done too.

Yes, other approaches could be to:

- not to search until the 2nd (or perhaps 3rd) characters are typed

- a slightly deeper but user invisible solution could be to delay longer for short strings, so for 1st character the timeout delay is twice the usual default? 

Having said the above, I've not yet hit this issue when searching the logs during my years looking through logs I see here on the XOs during normal usage/testing, the display of a one character search seems pretty instantaneous. What log is it that is getting so huge?

Any one know what the current delay is on the home view search, I've not looked at the code yet but feels like a 2sec timeout.

> I am not sure about changing the color in the entry. Is a nice feature,
> but is not used in any other place (in Sugar).

Yea, -1 for colour change, we don't use that any where else in Sugar, colour is usually reserved to indicate user ownership. If the implementation has a count of the search hits it would be nice to show the number of matches in the toolbar, but we are a little short of space unless the advanced features (Delete log, Log collector) in the cog secondary toolbar are moved into the Activity secondary toolbar (Log collector should certainly be treated as a save/export type feature as it just zips up log files into a Journal entry).

> Anyway, this is a very
> special activity, more useful for hacking and testing than as a educative
> tool.
> What do you think, Design Team?
> 
> Gonzalo
> 
> PD: Yes, I know, hacking and testing is educative too :)
> Gonzalo

;)

--Gary

> On Thu, Apr 12, 2012 at 7:58 PM, Manuel Kaufmann <humitos at gmail.com> wrote:
> 
>> On Thu, Apr 12, 2012 at 19:55, Manuel Kaufmann <humitos at gmail.com> wrote:
>>> Mmm... I'm not sure about this. If the user press just the "a" and the
>>> delay time is expired it will consume too much CPU.
>> 
>> Besides, what is a delay time accordingly for children? I mean, maybe
>> for a six-year-old kid 2 seconds is not enough and for a
>> twelve-year-old kid is too much.
>> 
>> I don't know. Personally, I don't like this approach :)
>> 
>> --
>> Kaufmann Manuel
>> Blog: http://humitos.wordpress.com/
>> Porfolio: http://fotos.mkaufmann.com.ar/
>> PyAr: http://www.python.com.ar/
>>