[Sugar-devel] [PATCH Log v2] Don't update search results every keystroke

Manuel Kaufmann humitos at gmail.com
Fri Apr 13 10:04:54 EDT 2012


On Fri, Apr 13, 2012 at 08:27, Gary Martin <garycmartin at googlemail.com> wrote:
>> I am not sure about changing the color in the entry. Is a nice feature,
>> but is not used in any other place (in Sugar).
>
> Yea, -1 for colour change, we don't use that any where else in Sugar,

Well, my patch changes the color and uses Key for new search results
because of this comment in the ticket[1]:

"To borrow what seems to be a common (but not necessarily the most
user obvious?) Sugar search box approach, we likely should return new
search results in Log only when the <Enter> key is pressed, and
somehow indicate when no results are returned as well."

I thought that search with Enter was a kind of standard, so I used it
in my patch. About colors, I didn't know what to do to show that were
no results, so I proposed this approach (stolen from Firefox's search
bar)

With these said, I will do what you say in the new patch :)

[1] http://bugs.sugarlabs.org/ticket/2734

-- 
Kaufmann Manuel
Blog: http://humitos.wordpress.com/
Porfolio: http://fotos.mkaufmann.com.ar/
PyAr: http://www.python.com.ar/


More information about the Sugar-devel mailing list