[Sugar-devel] [PATCH] Playlist for Jukebox

[Gonzalo Odiard]

> [widgets.py]
> > @@ -0,0 +1,87 @@
> > +# This program is free software; you can redistribute it and/or
> > +# modify it under the terms of the GNU Lesser General Public
> > +# License as published by the Free Software Foundation; either
> > +# version 2.1 of the License, or (at your option) any later version.
>
> Please consider using LGPL v3 (or even GPLv3 - I don't see why you'd
> want proprietary code to be able to use widgets.py), following the
> recent referendum on licenses for Sugar Labs projects. [3]
>
> This is a recommendation only - as a contributor, it's your choice how
> you license your code (and the maintainers choice whether to accept
> contributions under a given license).
>
>
Please no. Use the same license used in the activity.
I am maintaining the activity right now, and I prefer keep the version 2
license

Gonzalo


> > +# This library is distributed in the hope that it will be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> > +# Lesser General Public License for more details.
> > +#
>
> > +# You should have received a copy of the GNU Lesser General Public
> > +# License along with this library; if not, write to the Free Software
> > +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
> > +# USA
>
> As a side effect, switching to the recommended (L)GPLv3 boilerplate text
> would get rid of the outdated FSF address.
>
> > +import logging
> > +from gettext import gettext as _
> > +
> > +import pygtk
> > +pygtk.require('2.0')
>
> It doesn't hurt to do this, but every system running Sugar is using
> GTK 2, so no need to check for it.
>
>
> Note: I'm just pointing out a few pieces of code that I think could be
> done in a better way. Whether or not the maintainer of Jukebox agrees
> with my point of view and would accept the changes I suggested I do not
> know.
>
> Sascha
>
> [1] https://bugs.sugarlabs.org/ticket/1553
> [2] http://lists.laptop.org/pipermail/devel/2011-July/032529.html
> --
> http://sascha.silbe.org/
> http://www.infra-silbe.de/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110927/95b29cf1/attachment-0001.html>