<div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><div class="im"> [widgets.py] > @@ -0,0 +1,87 @@ > +# This program is free software; you can redistribute it and/or > +# modify it under the terms of the GNU Lesser General Public > +# License as published by the Free Software Foundation; either > +# version 2.1 of the License, or (at your option) any later version. </div>Please consider using LGPL v3 (or even GPLv3 - I don't see why you'd want proprietary code to be able to use widgets.py), following the recent referendum on licenses for Sugar Labs projects. [3] This is a recommendation only - as a contributor, it's your choice how you license your code (and the maintainers choice whether to accept contributions under a given license). <div class="im"> </div></blockquote><div> Please no. Use the same license used in the activity. I am maintaining the activity right now, and I prefer keep the version 2 license Gonzalo </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="im"> > +# This library is distributed in the hope that it will be useful, > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > +# Lesser General Public License for more details. > +# > +# You should have received a copy of the GNU Lesser General Public > +# License along with this library; if not, write to the Free Software > +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 > +# USA </div>As a side effect, switching to the recommended (L)GPLv3 boilerplate text would get rid of the outdated FSF address. <div class="im"> > +import logging > +from gettext import gettext as _ > + > +import pygtk > +pygtk.require('2.0') </div>It doesn't hurt to do this, but every system running Sugar is using GTK 2, so no need to check for it. Note: I'm just pointing out a few pieces of code that I think could be done in a better way. Whether or not the maintainer of Jukebox agrees with my point of view and would accept the changes I suggested I do not know. Sascha [1] <a href="https://bugs.sugarlabs.org/ticket/1553" target="_blank">https://bugs.sugarlabs.org/ticket/1553</a> [2] <a href="http://lists.laptop.org/pipermail/devel/2011-July/032529.html" target="_blank">http://lists.laptop.org/pipermail/devel/2011-July/032529.html</a> -- <a href="http://sascha.silbe.org/" target="_blank">http://sascha.silbe.org/</a> <a href="http://www.infra-silbe.de/" target="_blank">http://www.infra-silbe.de/</a> </blockquote></div>