[Sugar-devel] [DESIGN] Re: [PATCH 3/3] better wording #1508 + pep8 fixes
rafael at activitycentral.com
Mon May 23 10:28:43 EDT 2011
On Sat, May 21, 2011 at 8:13 AM, Sascha Silbe <silbe at activitycentral.com>wrote:
> Excerpts from Rafael Ortiz's message of Fri May 20 22:36:09 +0200 2011:
> > This patch proposes a better wording for cancel/stop buttons while
> exiting browse activity
> > plus pep8 fixes for downloadmanager.py
> Your patch doesn't apply to current mainline master (even with
> "git am -3"). However I've fixed everything complained about by the
> "pep8" tool now, including the ones you fixed.
> Funny, I did nothing out of the ordinary here, thanks for fixing it though!
> As for the string changes, I'd like the Design Team to comment on that
> before pushing them to mainline.
> @Gary, Walter: Context is SL#1508  "confusing wording on download
> from Browse". Rafael proposes to change "Cancel" to "Continue Download"
> and "Stop" to "Cancel Download".
> I like the first change, but maybe we can still improve on the second
> one? "Stop Download" maybe? We keep the partially downloaded file in the
> > @@ -598,9 +598,9 @@ class WebActivity(activity.Activity):
> > - alert.add_button(gtk.RESPONSE_CANCEL, _('Cancel'),
> > + alert.add_button(gtk.RESPONSE_CANCEL, _('Continue
> Download'), cancel_icon)
> > stop_icon = Icon(icon_name='dialog-ok')
> > - alert.add_button(gtk.RESPONSE_OK, _('Stop'), stop_icon)
> > + alert.add_button(gtk.RESPONSE_OK, _('Cancel Download'),
>  https://bugs.sugarlabs.org/ticket/1508
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Sugar-devel