[Sugar-devel] [DESIGN] Re: [PATCH 3/3] better wording #1508 + pep8 fixes

[Sascha Silbe]

Excerpts from Rafael Ortiz's message of Fri May 20 22:36:09 +0200 2011:

> This patch proposes a better wording for cancel/stop buttons while exiting browse activity 
> plus pep8 fixes for downloadmanager.py

Your patch doesn't apply to current mainline master (even with
"git am -3"). However I've fixed everything complained about by the
"pep8" tool now, including the ones you fixed.

As for the string changes, I'd like the Design Team to comment on that
before pushing them to mainline.

@Gary, Walter: Context is SL#1508 [1] "confusing wording on download
from Browse". Rafael proposes to change "Cancel" to "Continue Download"
and "Stop" to "Cancel Download".

I like the first change, but maybe we can still improve on the second
one? "Stop Download" maybe? We keep the partially downloaded file in the
Journal.

[webactivity.py]
> @@ -598,9 +598,9 @@ class WebActivity(activity.Activity):
[...]
> -            alert.add_button(gtk.RESPONSE_CANCEL, _('Cancel'), cancel_icon)
> +            alert.add_button(gtk.RESPONSE_CANCEL, _('Continue Download'), cancel_icon)
>              stop_icon = Icon(icon_name='dialog-ok')
> -            alert.add_button(gtk.RESPONSE_OK, _('Stop'), stop_icon)
> +            alert.add_button(gtk.RESPONSE_OK, _('Cancel Download'), stop_icon)

Sascha

[1] https://bugs.sugarlabs.org/ticket/1508
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 494 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110521/1ed98287/attachment.pgp>