[Sugar-devel] [PATCH] add update to keep callback to prevent data loss

[Simon Schampijer]

On 06/24/2011 02:46 PM, Walter Bender wrote:
> On Fri, Jun 24, 2011 at 8:37 AM, Walter Bender<walter.bender at gmail.com>  wrote:
>> On Fri, Jun 24, 2011 at 8:35 AM, Simon Schampijer<simon at schampijer.de>  wrote:
>>> On 06/22/2011 01:57 PM, Walter Bender wrote:
>>>>
>>>> From: Walter Bender<walter.bender at gmail.com>
>>>>
>>>> Patch to fix data loss problem with keep button
>>>>
>>>> "clicking star causes newly typed description to disappear"
>>>> (http://bugs.sugarlabs.org/ticket/2926)
>>>
>>> Thanks Walter for the patch. The issue is that clicking on the keep button
>>> does not trigger a focus out event which would have saved the metadata of
>>> the description field.
>>>
>>> Based on your idea I moved the write of the favorite icon to
>>> '_update_entry'. I hope this makes it a bit clearer and we only trigger one
>>> write, patch attached. Let me know what you think.
>>
>> That probably is a more sensible approach. I'll test your patch.
>
> Works!! Thanks.
>
> -walter

Thanks Walter, pushed it:

http://git.sugarlabs.org/sugar/mainline/commit/84f08da0d73ec2da47cc0b51855bf700d0c1075d

http://git.sugarlabs.org/sugar/mainline/commit/84f08da0d73ec2da47cc0b51855bf700d0c1075d

Regards,
    Simon