[Sugar-devel] [PATCH] Record: icons for the toolbar that replace strings "timer" and "duration"

[Daniel Drake]

Hi Manuel,

On 17 July 2011 23:33, Manuel Quiñones <manuq at laptop.org> wrote:
> There was positive feedback from the design team to do this change,
> because the issue in the toolbar described in SL tracker, ticket
>
> This implementation adds the same icon in each item of the combo box.
> see the design discussion.  It is here:
> http://lists.sugarlabs.org/archive/sugar-devel/2011-June/032024.html

Thanks again for the patch.

You need to mention in the commit message exactly what problem this is solving.

The discussion with Gary looks fruitful but it doesn't seem quite
completed yet - Gary hasn't seen/confirmed the final design. I won't
apply this to master just yet - but it looks like you are 99% there.

The gobject import in iconcombobox is no longer needed. And relying on
the icons path using os.path.join('icons') relies on the current
working directory being set to the activity, which is not always the
case. Instead you can use the icon_name mechanism and the icons will
be found automatically.

For OLPC we decided to include this in 11.2.0 even though it hasn't
quite passed through the whole process, here is the patch I will use:
http://dev.laptop.org/~dsd/20110718/0001-Use-icons-rather-than-strings-in-main-toolbar-for-ti.patch

Thanks for your hard work - almost there!
Daniel