[Sugar-devel] [PATCH] Sugar-toolkit: Pack page in ToolbarButton when is conected to the window - OLPC #10930

Gonzalo Odiard gonzalo at laptop.org
Tue Jul 12 15:18:30 EDT 2011

Thanks Simon, attached is a patch with the comments you did.

> The patch does double the "No gtk.AccelGroup in the top level window"
warnings printed in the logs.
> I don't think those are really useful for anything I would remove that (in
a separate patch for master) and if at all add a comment there.

May be we can remove the callback when the accelerator is set, and add it
again if the accelerator is changed.
I did not wanted to do it in this patch because the patch would be more
difficult to test/understand/review/accept
but can be a god improvement.


> Regards,
>   Simon
> ______________________________**_________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.**org <Sugar-devel at lists.sugarlabs.org>
> http://lists.sugarlabs.org/**listinfo/sugar-devel<http://lists.sugarlabs.org/listinfo/sugar-devel>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110712/8e860d49/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Sugar-toolkit-Pack-page-in-ToolbarButton-when-is-con.patch
Type: text/x-patch
Size: 1709 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110712/8e860d49/attachment.bin>

More information about the Sugar-devel mailing list