[Sugar-devel] [PATCH] Sugar-toolkit: Pack page in ToolbarButton when is conected to the window - OLPC #10930

[Simon Schampijer]

On 07/12/2011 09:18 PM, Gonzalo Odiard wrote:
> Thanks Simon, attached is a patch with the comments you did.
>
>> The patch does double the "No gtk.AccelGroup in the top level window"
> warnings printed in the logs.
>> I don't think those are really useful for anything I would remove that (in
> a separate patch for master) and if at all add a comment there.
>
> May be we can remove the callback when the accelerator is set, and add it
> again if the accelerator is changed.
> I did not wanted to do it in this patch because the patch would be more
> difficult to test/understand/review/accept
> but can be a god improvement.
>
> Gonzalo

Thanks Gonzalo, pushed.

http://git.sugarlabs.org/sugar-toolkit/mainline/commit/3a81ba74385881b8638e800cdfdbb73a3708e7af

Yes, let's discuss the rest in a follow-up patch, can you open us a 
reminder bug?

Regards,
    Simon