[Sugar-devel] [PATCH sugar 0/2] Escape user data and translations in markup

Daniel Drake dsd at laptop.org
Thu Jul 7 20:16:57 EDT 2011


On 2 July 2011 20:55, Sascha Silbe <silbe at activitycentral.com> wrote:
> It does make sense, but it would be an incompatible API change.
> Activities that don't use markup would need to handle the escaping for
> Sugar <= 0.92 and must not escape the text for Sugar 0.94+. Similarly,
> activities that do use markup would need to pass *_text for <= 0.92 and
> *_markup for 0.94+.
>
> Since we have no (other) API changes in master currently I wonder
> whether this is something better done in the GTK3 port.

Thats a good idea. So yes, for now your patch looks good to me.
Perhaps you could add a code comment reminding us to fix(break) this
API in future?

Thanks,
Daniel


More information about the Sugar-devel mailing list