[Sugar-devel] [PATCH sugar 0/2] Escape user data and translations in markup

[Sascha Silbe]

Excerpts from Daniel Drake's message of Mon Jun 27 13:24:14 +0200 2011:

> On 26 June 2011 19:06, Sascha Silbe <silbe at activitycentral.com> wrote:
> > While chasing down a similar bug in the Clock Frame device, I noticed that
> > we're lacking the necessary escaping in most of Sugar. See SL#2099 for an
> > example of what can happen if we don't.

> This looks like it will be easily overlooked in the future as well.
> Wouldn't it make more sense to modify the standard Palette and
> MenuItem APIs so that they don't accept markup, and add a second API
> for markup users? I imagine that there are only a handful of users
> that actually want markup here.

It does make sense, but it would be an incompatible API change.
Activities that don't use markup would need to handle the escaping for
Sugar <= 0.92 and must not escape the text for Sugar 0.94+. Similarly,
activities that do use markup would need to pass *_text for <= 0.92 and
*_markup for 0.94+.

Since we have no (other) API changes in master currently I wonder
whether this is something better done in the GTK3 port.

Sascha

-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 500 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20110702/50d73ec0/attachment.pgp>