[Sugar-devel] [PATCH] Increase timeout for buddy properties queries #2298

[Tomeu Vizoso]

On Tue, Sep 7, 2010 at 14:55, Sascha Silbe
<sascha-ml-reply-to-2010-3 at silbe.org> wrote:
> Excerpts from Tomeu Vizoso's message of Tue Sep 07 13:40:28 +0200 2010:
>
>> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.co.uk>
>
> A long description would be nice. The docstring from your patch would do
> fine.

Ok.

>> +_QUERY_DBUS_TIMEOUT = 200
>
> 200 seconds (over 3 minutes) is a really long time for updating the
> Neighborhood.

Well, it's the time from when we ask for extended information about a
buddy until the answer comes. Presently we are using dbus' default
which is 25 seconds. I think values of 50, 100 or 500 would be equally
good because jabber servers are supposed to reply always.

> I'm curious, what are the actual times you encountered
> during testing?

It could go from 3-4 seconds to 30-40.

> Do you have any idea why the server might be that slow?

Most probably some throttling done by ejabberd because we are making
many more PEP queries than what other clients would do.

Scratch that, just peeked into the server and ejabberd just cannot get
enough CPU to answer the queries.

I think we can assume that in this case the long time that a query
takes to be processed is due to a defect in the server, but because
servers use to do throttling and we request a considerable amount of
information in short bursts, I think it would make sense to increase
the default dbus timeout for these queries. But there's no rush at
all, we can do so after more testing is done.

Will give more details in the other open thread about ejabberd and the
school server.

>> +"""
>> +Time in seconds to wait when querying contact properties. Some jabber servers
>> +will be very slow in returning these queries, so just be patient.
>> +"""
>
> Is there a special reason you used a docstring after the variable
> instead of a comment before it?

It's what http://www.python.org/dev/peps/pep-0257/ calls "attribute
docstring", it could be extracted by documentation tools.

Regards,

Tomeu

> Sascha
>
> --
> http://sascha.silbe.org/
> http://www.infra-silbe.de/
>
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
>