[Sugar-devel] [PATCH] Increase timeout for buddy properties queries #2298

Sascha Silbe sascha-ml-reply-to-2010-3 at silbe.org
Tue Sep 7 08:55:19 EDT 2010


Excerpts from Tomeu Vizoso's message of Tue Sep 07 13:40:28 +0200 2010:

> Signed-off-by: Tomeu Vizoso <tomeu.vizoso at collabora.co.uk>

A long description would be nice. The docstring from your patch would do
fine.

> +_QUERY_DBUS_TIMEOUT = 200

200 seconds (over 3 minutes) is a really long time for updating the
Neighborhood. I'm curious, what are the actual times you encountered
during testing? Do you have any idea why the server might be that slow?

> +"""
> +Time in seconds to wait when querying contact properties. Some jabber servers
> +will be very slow in returning these queries, so just be patient.
> +"""

Is there a special reason you used a docstring after the variable
instead of a comment before it?

Sascha

--
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100907/641a5be5/attachment.pgp 


More information about the Sugar-devel mailing list