[Sugar-devel] ticket #2318 display free journal space in volume toolbar

Aleksey Lim alsroot at member.fsf.org
Sat Oct 16 15:57:04 EDT 2010

On Sun, Oct 17, 2010 at 12:58:27AM +0530, Ishan Bansal wrote:
> Hi Aleksey
> I had submitted the patch for the http://bugs.sugarlabs.org/ticket/2318
> You can check the patch at
> http://www.mail-archive.com/sugar-devel@lists.sugarlabs.org/msg16721.html
> Wish if you could review it and provide me feedback on any improvement
> required.

You need to check your patch (only your patch, the rest of code does not
conform all checks) w/ pylint/pep8 (eg using sugar-lint[1]).

> +        label = 'Journal'
string needs to be kept gettextized ie _('Journal')

[1] http://wiki.sugarlabs.org/go/Activity_Team/Sugar_Lint


More information about the Sugar-devel mailing list