[Sugar-devel] [PATCH v4 sugar] Time out on registration process to prevent indefinite UI hang (SL#2289)

[James Cameron]

On Mon, Oct 11, 2010 at 08:39:12PM +0200, Simon Schampijer wrote:
> On 09/21/2010 02:46 AM, James Cameron wrote:
> >On Mon, Sep 20, 2010 at 08:15:59PM +0530, Dipankar Patro wrote:
> >>Registration with the school server is currently done synchronously.
> >>To prevent the UI from hanging indefinitely, if the school server is reachable
> >>but unresponsive, we add an explicit timeout.
> >>---
> >>  src/jarabe/desktop/schoolserver.py |   27 ++++++++++++++++++++++++---
> >>  1 files changed, 24 insertions(+), 3 deletions(-)
> >>
> >>v2 was Reviewed-By: Sascha Silbe<sascha-pgp at silbe.org>
> >>v3 was Reviewed-By: Sascha Silbe<sascha-pgp at silbe.org>
> >>v3->v4: Rebased on current mainline/master
> >
> >Reviewed-By: James Cameron<quozl at laptop.org>
> >
> 
> This one has been ack'ed right? I can find no commit.

I see no ack.  I see no commit.

http://patchwork.sugarlabs.org/patch/260/ has the two reviewed-by tags.

> As we have discovered those two bugs maybe we should land it in 0.90.1
> and of course master?

I see no significant reason why this should not be fixed for 0.90.1.

Insignificant reasons are use of undocumented internals and the way that
the port argument to TimeoutHTTP is checked without obvious reason.

-- 
James Cameron
http://quozl.linux.org.au/