[Sugar-devel] [PATCH 06/21 sugar-toolkit] PEP8 cleanup: fix inline comment spacing

[Simon Schampijer]

On 11/19/2010 05:31 PM, Sascha Silbe wrote:
> Excerpts from Simon Schampijer's message of Fri Oct 29 12:50:30 +0200 2010:
>
> [reordered quotes to make the context clear]
>
> [src/sugar/presence/activity.py]
>>> @@ -683,11 +683,16 @@ class _JoinCommand(_BaseCommand):
>>>            # since only the owner can change invite-only, that would break
>>>            # activity scope changes.
>>>            props = {
>>> -            'anonymous': False,   # otherwise buddy resolution breaks
>>> -            'invite-only': False, # anyone who knows about the channel can join
>>> -            'invite-restricted': False,     # so non-owners can invite others
>>> -            'persistent': False,  # vanish when there are no members
>>> -            'private': True,      # don't appear in server room lists
>>> +            # otherwise buddy resolution breaks
>>> +            'anonymous': False,
>>> +            # anyone who knows about the channel can join
>>> +            'invite-only': False,
>>> +            # so non-owners can invite others
>>> +            'invite-restricted': False,
>>> +            # vanish when there are no members
>>> +            'persistent': False,
>>> +            # don't appear in server room lists
>>> +            'private': True,
>>>            }
>
>> In the second case in this patch I think having them in the same line is
>> easier to read. Might be taste. A lot of those comments are not that
>> helpful anyway - we should revise them in another go.
>
> At least one of the existing comments was past the 79 character boundary,
> so I would have had to either put it on two lines (but still inline) or
> make just that one comment non-inline. I don't like either of those
> choices. :)
>
> Sascha

Is fine with me, I don't feel strongly about it.

Regards,
    Simon