[Sugar-devel] [PATCH v1 00/10] Journal sorting by file size and creation time.

[Andrés Ambrois]

On Sunday 23 May 2010 04:08:51 pm Michael Stone wrote:
> Andrés,
> 
> I've read these patches and tested them locally (with minor changes due to
> merge conflicts with some of my experimental work) and the results are quite
> pleasing to me.

Thanks!

> The one issue that I would like you to fix before I merge these patches into 
my
> tree is that I would like you to include additional patches for the new 
icons
> that your ListViewButton requires to function as intended. 
> 
> (I don't really care whether the new icons are different from the old icons; 
I
> merely care that I still have a normal-looking ListViewButton after I select
> one of your new sort modes rather than the thin grey bar that I currently 
see.)

I only have the filesize icon I made for testing, but I usually stay away from 
graphics work (I suck at GIMP). 

Gary, I see you uploaded [0] to the wiki, which is what this patchset is based 
on. Do you have SVG versions of the icons you put in there?

> Regards, and thanks for all your hard work here,

Thank you for reviewing!

> Michael
> 
[0] 
http://wiki.sugarlabs.org/go/File:Journal_mockup_gary_list_extended_palette.png
-- 
  -Andrés
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100523/d2a5263e/attachment.pgp