[Sugar-devel] [PATCH v1 00/10] Journal sorting by file size and creation time.

[Michael Stone]

On Sun, May 23, 2010 at 09:02:30AM -0300, Andrés Ambrois wrote:
>See [0] for the rationale behind this patchset.
>
>[0] http://lists.sugarlabs.org/archive/sugar-devel/2010-May/023664.html
>
>v0: Initial submission to sugar-devel
>v1: Separated ctime and filesize patches. Implemented sorting for removable devices.
>
>Andrés Ambrois (10):
>  Journal: Retrieve filesize from the datastore
>  Add a filesize column to the journal list model
>  Journaltoolbox: Add add_separator method for convenience.
>  Add a ListViewButton to the journal search toolbar.
>  Rename the date column to 'sort_column'
>  Display the sorting property in the last column.
>  Expandedentry: Try to use the filesize property.
>  Implement sorting for removable devices.
>  Add sort by creation time option to the ListViewButton
>  Add ctime property to the journal model.
>
> src/jarabe/journal/expandedentry.py  |    5 +-
> src/jarabe/journal/journaltoolbox.py |   86 ++++++++++++++++++++++++++++++++++
> src/jarabe/journal/listmodel.py      |   22 ++++++--
> src/jarabe/journal/listview.py       |   33 +++++++------
> src/jarabe/journal/model.py          |   22 ++++++--
> 5 files changed, 140 insertions(+), 28 deletions(-)
>

Andrés,

I've read these patches and tested them locally (with minor changes due to
merge conflicts with some of my experimental work) and the results are quite
pleasing to me.

The one issue that I would like you to fix before I merge these patches into my
tree is that I would like you to include additional patches for the new icons
that your ListViewButton requires to function as intended. 

(I don't really care whether the new icons are different from the old icons; I
merely care that I still have a normal-looking ListViewButton after I select
one of your new sort modes rather than the thin grey bar that I currently see.)

Regards, and thanks for all your hard work here,

Michael