[Sugar-devel] New Chapter in Make Your Own Sugar Activities needs review

[Bert Freudenberg]

On 30.03.2010, at 16:46, James Simmons wrote:
> 
> Bert and Sascha,
> 
> In the book I'm trying to encourage practices that work in multiple
> versions of Sugar.  I tried what Bert proposed last night and it
> worked fine, so that's what I'm going to write up in the book.  The
> book is for beginners (mostly) so I'm trying to avoid burdening the
> reader with information he has no use for.
> 
> The latest changes to Sugar Commander are in Git:
> 
> http://git.sugarlabs.org/projects/sugar-commander
> 
> I'm going to test this on my XO at lunch.  It's already worked fine in
> testing on F10 and F11.  If I don't see any issues I'll update ASLO
> and the book.  In the meantime, if you want to check my code and make
> suggestions I'd be grateful.
> 
> Thanks,
> 
> James Simmons

I'd have expected the "Updated" signal to be used like this:

    def _datastore_updated_cb(self,  uid):
        if uid == jobject.object_id:
            self.update_details()

where update_details() would be factored out from the body of selection_journal_cb() ...

- Bert -