[Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

[Sascha Silbe]

Excerpts from Anish Mangal's message of Tue Jun 29 21:16:52 +0000 2010:

> 1. On f13 based sugar environments (such as soas3, jhbuild-0.88), this
> patch will occasionally cause Browse to crash when closing tabs. This
> probably happens because of a bug [1] (or something very similar to
> this). As a workaround, one can downgrade the cairo package from
> cairo-1.8.10 to cairo-1.8.8-1.fc11 (or upgrade to the latest
> development version 1.9.10-1, though I haven't tested that).
This is supposed to be fixed in Debian, but it still crashes for me. So even though I like the feature I have to NAK this patch for now.

BTW: I recommend using coloured diffs to catch whitespace errors (take a look at _add_tab_cb() in your patch):

git config --global color.diff auto

Sascha

--
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
Url : http://lists.sugarlabs.org/archive/sugar-devel/attachments/20100630/094fe2e1/attachment.pgp