[Sugar-devel] [PATCH] Browse: Add support for creating multiple tabs

[Bernie Innocenti]

El Tue, 29-06-2010 a las 22:26 +0100, Lucian Branescu escribió:
> I'm not sure it's a good idea to merge this if it causes Browse (vital
> app) to occasionally crash on SoaS (very popular Sugar environment).
> At the very least, the tabs feature should be disabled if that certain
> version of cairo is detected.

I'd go for the workaround, as we'd really want this feature merged in
time for F11-0.88.

Meanwhile, can someone please file a bug in RedHat's bugzilla? I've cc'd
the current Cairo maintainer in Fedora. Benjamin, this is the equivalent
bug in Debian: 

  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=551852


On 29 June 2010 22:19, Anish Mangal <anishmangal2002 at gmail.com> wrote:
> >> 1. On f13 based sugar environments (such as soas3, jhbuild-0.88),
this
> >
> > Oops, I meant soas3 and jhbuild-0.88 running on f13.
> >
> > On Wed, Jun 30, 2010 at 2:46 AM, Anish Mangal
<anishmangal2002 at gmail.com> wrote:
> >> Note:
> >>
> >> 1. On f13 based sugar environments (such as soas3, jhbuild-0.88), this
> >> patch will occasionally cause Browse to crash when closing tabs. This
> >> probably happens because of a bug [1] (or something very similar to
> >> this). As a workaround, one can downgrade the cairo package from
> >> cairo-1.8.10 to cairo-1.8.8-1.fc11 (or upgrade to the latest
> >> development version 1.9.10-1, though I haven't tested that).
> >>
> >> 2. This patch doesn't add an entry 'open link in new tab' to the
> >> context menu. That can come as a separate patch.
> >>
> >>
> >> [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=551852
> >>
> >> --
> >> Anish Mangal
> >> anish at sugarlabs.org

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/