[Sugar-devel] RFC: Kill the delayed menus for good

[Bernie Innocenti]

El Fri, 16-10-2009 a las 09:44 +0545, Daniel Drake escribió:
> OK then, that sounds a lot better. I'm surprised that this point
> wasn't raised earlier.
> 
> Given that this thread is largely about process, let me throw in one
> more point then: all patches should be accompanied with a good
> description of the change that they actually make :)

+1, but in this case this was just an RFC meant to let people test the
new behavior and comment on it.

Surprisingly, a lot of feedback came from people who had not actually
tried the patch or even *looked* at it! Lack of expertise is not a good
excuse as we claim that even children could make changes to Sugar.

Here's Michael's patch again (attached below). As can be seen, it's
really as trivial as changing just 3 bytes in two files (it's really 3
changed bytes and 1 added byte, but it could be done in just 3
moves :-).

One could also edit the files in-place from a SoaS or XO image:

  vi /lib/python2.6/site-packages/sugar/graphics/palette.py +106
  vi /lib/python2.6/site-packages/sugar/graphics/palettewindow.py +151


From: Michael Stone <michael at laptop.org>
Date: Mon, 14 Sep 2009 22:33:12 -0400
Subject: Make various palette animations happen more quickly.

---
 src/sugar/graphics/palette.py       |    2 +-
 src/sugar/graphics/palettewindow.py |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/sugar/graphics/palette.py b/src/sugar/graphics/palette.py
--- a/src/sugar/graphics/palette.py
+++ b/src/sugar/graphics/palette.py
@@ -103,7 +103,7 @@ class Palette(PaletteWindow):
 
         self._menu_content_separator = gtk.HSeparator()
 
-        self._secondary_anim = animator.Animator(2.0, 10)
+        self._secondary_anim = animator.Animator(0.0, 10)
         self._secondary_anim.add(_SecondaryAnimation(self))
 
         # we init after initializing all of our containers
diff --git a/src/sugar/graphics/palettewindow.py b/src/sugar/graphics/palettewindow.py
--- a/src/sugar/graphics/palettewindow.py
+++ b/src/sugar/graphics/palettewindow.py
@@ -148,10 +148,10 @@ class PaletteWindow(gtk.Window):
         self._up = False
         self._old_alloc = None
 
-        self._popup_anim = animator.Animator(.5, 10)
+        self._popup_anim = animator.Animator(0.0, 10)
         self._popup_anim.add(_PopupAnimation(self))
 
-        self._popdown_anim = animator.Animator(0.6, 10)
+        self._popdown_anim = animator.Animator(0.0, 10)
         self._popdown_anim.add(_PopdownAnimation(self))
 
         gobject.GObject.__init__(self, **kwargs)
-- 
1.5.6.5

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/