[Bugs] #2157 IMME: reimplement sugar.presence so it doesn't use the Presence Service

Sugar Labs Bugs bugtracker-noreply at sugarlabs.org
Thu Aug 19 12:21:23 EDT 2010


#2157: reimplement sugar.presence so it doesn't use the Presence Service
------------------------------+---------------------------------------------
    Reporter:  tomeu          |          Owner:  erikos     
        Type:  enhancement    |         Status:  new        
    Priority:  Immediate      |      Milestone:  0.90       
   Component:  sugar-toolkit  |        Version:  Unspecified
    Severity:  Unspecified    |       Keywords:  r?         
Distribution:  Unspecified    |   Status_field:  Assigned   
------------------------------+---------------------------------------------

Comment(by erikos):

 activity.py:

 There are 4 cases we have to handle in the constructor: invited, join,
 share_previously_shared and the private case. I would probably put that
 into private methods and reflect that in the naming. Like:

 {{{
 if shared_instance is not None:
     self._join_instance()
 elif share_scope != SCOPE_PRIVATE:
     self._share_previously_shared_instance(...)
 else:
     self.__initialize_journal_object(...)
 }}}

 if handle.invited: does speak for itself. And as we nearly touch all
 mesh_instance cases please rename it :)

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/2157#comment:4>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system


More information about the Bugs mailing list