[Bugs] #2157 IMME: reimplement sugar.presence so it doesn't use the Presence Service

[Sugar Labs Bugs]

#2157: reimplement sugar.presence so it doesn't use the Presence Service
------------------------------+---------------------------------------------
    Reporter:  tomeu          |          Owner:  erikos     
        Type:  enhancement    |         Status:  new        
    Priority:  Immediate      |      Milestone:  0.90       
   Component:  sugar-toolkit  |        Version:  Unspecified
    Severity:  Unspecified    |       Keywords:  r!         
Distribution:  Unspecified    |   Status_field:  Assigned   
------------------------------+---------------------------------------------
Changes (by erikos):

  * keywords:  r? => r!


Comment:

 src/sugar/activity/activityhandle.py
 - thanks for changing it to handle.invited

 src/sugar/activity/activityservice.py
 - (please add a comment that it is deprecated)
 def Invite(self, buddy_key):
         raise NotImplementedError
 In the shell (jarabe.view.buddymenu) you are trying to call it:
 logging.warning('Trying deprecated Activity.Invite')
 service.Invite(self._buddy.props.key)
 Does this handle cases where old Sugar versions share with new ones?

 src/sugar/datastore/datastore.py
 - self._object_id = None  just a pylint fix, right?

 src/sugar/presence/connectionmanager.py
 - can you add a doc what it does and mark it unstable API as it is only of
 use to the sugar-PS?

 src/sugar/presence/presenceservice.py
 - please adjust the line: "UI class to access system-level presence
 object"
 - please adjust the docstring: "UI-side interface to the dbus presence
 service..."
 - remove the class OfflineInterface (not used anymore)
 - remove the 'activity-disappeared' etc signals as the shell does not
 listen to them anymore. From the s\
 ignals only 'activity-shared' seems to be in use.

 Btw, all the approach looks really good!

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/2157#comment:5>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system