[Sugar-devel] [PATCH Terminal 1/2] GTK3 Port start

[S. Daniel Francis]

Hi,

> -        vt.drag_dest_set(gtk.DEST_DEFAULT_MOTION | gtk.DEST_DEFAULT_DROP,
> > -               [('text/plain', 0, 0), ('STRING', 0, 1)],
> > -               gtk.gdk.ACTION_DEFAULT |
> > -               gtk.gdk.ACTION_COPY)
> > -        vt.connect('drag_data_received', self.__drag_data_received_cb)
> > +        #vt.drag_dest_set(Gtk.DestDefaults.MOTION |
> Gtk.DestDefaults.DROP,
> > +        #       [('text/plain', 0, 0), ('STRING', 0, 1)],
> > +        #       Gdk.DragAction.DEFAULT |
> > +        #       Gdk.DragAction.COPY)
> > +        #vt.connect('drag_data_received', self.__drag_data_received_cb)
>
>
> Why these lines are commented?
>
There were problems with drag and drop, and we didn't find utility
connecting the Vte Terminal to drag and drop events.


>
> > -        scrollbar = gtk.VScrollbar(vt.get_adjustment())
> > +        scrollbar = Gtk.VScrollbar(vt.get_vadjustment())
>
> I don't know why (yet) but I'm getting this error on Fedora 16 with
> jhbuild: http://fpaste.org/iyeO/
>
I don't have this problem with Debian Testing.
>
> > -        box = gtk.HBox()
> > -        box.pack_start(vt)
> > -        box.pack_start(scrollbar)
> > +        box = Gtk.HBox()
> > +        box.pack_start(vt, True, True, 0)
> > +        box.pack_start(scrollbar, True, True, 0)
>
> Here, you should pass False to the last box.pack_start:
>
> box.pack_start(scrollbar, False, True, 0)
>
> This is because you don't want to expand the ScrollBar, we want to put
> it just on the right of the screen.
>
> With True when a new tab is opened you will see a portion of the
> screen that is not used by Vte, instead it is used by the ScrollBar
> and if you open a new tab and switch between them many times you will
> get the correct proportion :)
>
> Yes, but if we pass True, Sugar doesn't show the Scrollbar in the Window,
there was a long discussion yesterday, in the Sugar Code Sprint about that.
I think there's missing a FIXME.

Regards,
Daniel Francis.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120515/97e7d992/attachment-0001.html>