[Sugar-devel] [PATCH] Record: stop recording with the same shutter key in gamepad

[Manuel Quiñones]

Hi James,

El día 12 de marzo de 2012 19:43, James Cameron <quozl at laptop.org> escribió:
> On Mon, Mar 12, 2012 at 05:02:10PM -0300, Manuel Qui??ones wrote:
>> Use the same shutter key in gamepad to stop the recording.
>>
>> This is for bug #3360 .
>
> Nak.
>
> Your patch binds the stop recording function to the O game key.
>
> I suggest instead that you bind it to the X game key, so that an
> accidental double press of the O game key does not cause a short
> recording, and so that the O game key does not act as a toggle.

You raised an interesting point.  So I was between two options: using
the same game key O for start recording/stop recording, and using
another game key, like [] or X .  I decided to go for the first one
because 1. that seemed to me analogous to the record button of a real
camera and 2. that seemed similar than using the buttons on the
screen, which looked like a toggle.  But I think you have a point
in...

> The problem with using a push button as a toggle is that the learner is
> forced to remember, without the display visible, whether the toggle is
> on or off.  This can lead to inverted state; where a series of videos
> are recorded consisting entirely of the time periods between those that
> should have been recorded.

...that happened to me with a real camera.  When I was back at home
and watched the footage, I hated the overloaded button.

> The use of the X game key would also be consistent with the use of X to
> mean stop.
>
> The X game key is easily found by touch, as it is on the other side of
> the game key diamond, just above the power button.
>
> On the other hand, the symbol for stop on screen is a square.  That
> would suggest the square game key may be also used.

I think I would go for the X button because it is easier to press.

> The same sound is used for both start and stop.  A different sound for
> stop would be another improvement.
>
> Lastly, I think bug #3360 would also be addressed by moving the start
> button to the same position that the stop button currently holds.
>
> This also might address a different problem that is sometimes seen: when
> the start button is pressed, there is a short time during which the
> previous recording "Saving" progress bar is made visible.

Yes, also have no sense to have the start button centered aligned, and
the stop button on the left.

If we use the same reasoning as with the gamepad but with the buttons
in the screen, then should we put the two buttons side by side, and
make one insensitive while the other is active? or a toggle is ok in
the screen?

If we have consensus and the maintainer allows me, I'll be happy to
work in the previous topics: a. new stop sound and b. buttons
alignment.

Thank you very much for the review James!

-- 
.. manuq ..