[Sugar-devel] [PATCH 5/5] sl#3149: Localization fixes.

[Chris Leonard]

Some are good, some are not, see below.

On Thu, Jan 19, 2012 at 4:36 PM, Ajay Garg <ajay at activitycentral.com> wrote:
>
> Signed-off-by: Ajay Garg <ajay at activitycentral.com>

> -    return ', '.join([_('%(interface)s: %(version)s') %
> +    return ', '.join(['%(interface)s: %(version)s' %

I think this is correct

> -            alert.props.msg = _('%s') % e
> +            alert.props.msg = '%s' % e

This looks good to me.

> -        self.progress_label.props.label = _('%s of %s') % (transferred, total)
> +        self.progress_label.props.label = '%s of %s' % (transferred, total)

I do not agree with this choice. I would leave it the way it was.
"of" is an English word.  Localizers can properly localize " %s of %s"


> -        label = glib.markup_escape_text(_('Transfer from %s') % (nick,))
> +        label = glib.markup_escape_text(_('Transfer from') + ' ' + nick)

I do not agree with this choice.  Concatenation is bad i18n practice,
I would leave it the way it was.

> -            label = gtk.Label(_('%s (%s)') % (size, type_description))
> +            label = gtk.Label('%s (%s)' % (size, type_description))


I think this is correct, I do not think "%s (%s)"  can be meaningfully
localized, at least not without a lot more context provided as a
developers comment.


> -        label = glib.markup_escape_text(_('Transfer to %s') % (nick,))
> +        label = glib.markup_escape_text(_('Transfer to') + ' ' + nick)

I do not agree with this choice.  Concatenation is bad i18n practice,
I would leave it the way it was.

> -            label = gtk.Label(_('%s (%s)') % (size, type_description))
> +            label = gtk.Label('%s (%s)' % (size, type_description))

I think this is correct, I do not think "%s (%s)"  can be meaningfully
localized, at least not without a lot more context provided as a
developers comment.

cjl