[Sugar-devel] [PATCH v3 sugar-toolkit-gtk3] Fix the drawing of ColorToolButton, RadioToolButton and ToggleToolButton

Gonzalo Odiard gonzalo at laptop.org
Mon Aug 27 13:36:25 EDT 2012


It's the toolbar size already solved? http://bugs.sugarlabs.org/ticket/3388

Gonzalo

On Mon, Aug 27, 2012 at 2:15 PM, Manuel Quiñones <manuq at laptop.org> wrote:

> 2012/8/27 Simon Schampijer <simon at schampijer.de>:
> > On 08/24/2012 02:13 AM, Manuel Quiñones wrote:
> >>
> >> Draw a black background in the buttons when the palette is up, as
> >> commit 01a06943 did with the ToolButton.  As the comment for that
> >> commit states, we can change the prelight background color in the
> >> theme, but not when the mouse moves over the Palette.
> >>
> >> Also add testcase to test the three toolbuttons.
> >>
> >> Signed-off-by: Manuel Quiñones <manuq at laptop.org>
> >>
> >> ---
> >>
> >> v2: Paint the background color as per Simon's feedback.
> >> v3: Add testcase.
> >
> >
> > Thanks Manuel for the follow up. Looks good to me now. Acked-by me.
>
> Thanks, pushed.
>
> > As a follow up we need to see the theming of the sliders in the color
> button
> > palette and the theming issue we diagnosed in .button:focused.
>
> Yes!  Patch coming for artwork.
>
> --
> .. manuq ..
> _______________________________________________
> Sugar-devel mailing list
> Sugar-devel at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120827/27baf991/attachment.html>


More information about the Sugar-devel mailing list