[Sugar-devel] [PATCH v3 sugar-toolkit-gtk3] Fix the drawing of ColorToolButton, RadioToolButton and ToggleToolButton

Manuel Quiñones manuq at laptop.org
Mon Aug 27 13:15:03 EDT 2012


2012/8/27 Simon Schampijer <simon at schampijer.de>:
> On 08/24/2012 02:13 AM, Manuel Quiñones wrote:
>>
>> Draw a black background in the buttons when the palette is up, as
>> commit 01a06943 did with the ToolButton.  As the comment for that
>> commit states, we can change the prelight background color in the
>> theme, but not when the mouse moves over the Palette.
>>
>> Also add testcase to test the three toolbuttons.
>>
>> Signed-off-by: Manuel Quiñones <manuq at laptop.org>
>>
>> ---
>>
>> v2: Paint the background color as per Simon's feedback.
>> v3: Add testcase.
>
>
> Thanks Manuel for the follow up. Looks good to me now. Acked-by me.

Thanks, pushed.

> As a follow up we need to see the theming of the sliders in the color button
> palette and the theming issue we diagnosed in .button:focused.

Yes!  Patch coming for artwork.

-- 
.. manuq ..


More information about the Sugar-devel mailing list