[Sugar-devel] [PATCH sugar 1/7] SugarEventIcon: Add a hippo-free implementation of the CanvasIcon

Sascha Silbe silbe at activitycentral.com
Mon Aug 6 07:25:43 EDT 2012


Simon Schampijer <simon at schampijer.de> writes:

> The icon consists of an GtkEventBox and an IconBuffer. The
> GtkEventBox is a subclass of GtkBin which has its own window
> and therefor is used to catch events for our IconBuffer
> which does not have it's own window.
[...]

This is fine from my side, but as discussed during the Development Team
meeting a few weeks ago, I'd like Benjamin (CC'ed) to have a look at it
to make sure there are no (obvious) problems with the approach that will
cause significant trouble further down the road.

If Benjamin doesn't have time to do the review, I'll just accept the
patch as-is.

Sascha
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120806/92752566/attachment.pgp>


More information about the Sugar-devel mailing list