[Sugar-devel] [PATCH sugar 4/7] Journal: set white background in the ExpandedEntry of the Detail View

Sascha Silbe silbe at activitycentral.com
Mon Aug 6 07:17:21 EDT 2012


Simon Schampijer <simon at schampijer.de> writes:

> Change the ExpandedEntry class to subclass gtk.EventBox because the
> gtk.VBox doesn't have a gtk.gdk.Window associated and the background
> can't be set otherwise.

Is this a bug affecting current mainline master or is it a result of
applying one of the other patches in this series? If the latter, please
include a reference to the patch that changes the behaviour and if
possible a reason for the breakage (i.e. why did it work before the
patch, but not afterwards?). Depending on the details, it may even make
sense to just squash these changes into the patch that changes the
behaviour.


> Acked-by: Simon Schampijer <simon at laptop.org>

Please use Reviewed-By: instead of Acked-by: when posting patches on
sugar-devel. Ack'ing should be the result of the public peer review, not
done beforehand in private. The review itself is rather welcome, of
course.

Sascha
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 489 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/sugar-devel/attachments/20120806/bde9fe11/attachment.pgp>


More information about the Sugar-devel mailing list